Skip to content

Conversation

@arvinxx
Copy link
Member

@arvinxx arvinxx commented Oct 30, 2025

💻 Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • ✅ test
  • 📝 docs
  • 🔨 chore

🔗 Related Issue

🔀 Description of Change

🧪 How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed

📸 Screenshots / Videos

Before After
... ...

📝 Additional Information

Summary by Sourcery

Remove Azure AD SSO provider support by deleting its module and removing its references from the ssoProviders list.

Chores:

  • Delete the azure-ad.ts provider file
  • Remove AzureAD import and entry from the SSO providers array

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 30, 2025
@vercel
Copy link

vercel bot commented Oct 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
lobehub Ready Ready Preview Comment Oct 30, 2025 6:31pm
lobehub-lite Building Building Preview Oct 30, 2025 6:31pm

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 30, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Remove AzureAD as an SSO provider by cleaning up its registration and deleting its module.

Class diagram for SSO providers after AzureAD removal

classDiagram
  class Auth0
  class Authentik
  class GenericOIDC
  class Github
  class Zitadel
  class ssoProviders {
    Auth0
    Authentik
    GenericOIDC
    Github
    Zitadel
  }
Loading

File-Level Changes

Change Details Files
Removed AzureAD from the provider registry
  • Dropped AzureAD import
  • Removed AzureAD entry in ssoProviders array
src/libs/next-auth/sso-providers/index.ts
Deleted the AzureAD provider module
  • Removed azure-ad.ts file
src/libs/next-auth/sso-providers/azure-ad.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gru-agent
Copy link
Contributor

gru-agent bot commented Oct 30, 2025

TestGru Assignment

Summary

Link CommitId Status Reason
Detail 9a23780 🚫 Skipped No files need to be tested {"src/libs/next-auth/sso-providers/azure-ad.ts":"File path does not match include patterns.","src/libs/next-auth/sso-providers/index.ts":"File path does not match include patterns."}

History Assignment

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.66%. Comparing base (6ec01a3) to head (9a23780).
⚠️ Report is 6 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #9942   +/-   ##
=======================================
  Coverage   83.66%   83.66%           
=======================================
  Files         950      950           
  Lines       65893    65893           
  Branches     9704     9706    +2     
=======================================
  Hits        55130    55130           
  Misses      10763    10763           
Flag Coverage Δ
app 78.85% <ø> (ø)
database 98.41% <ø> (ø)
packages/agent-runtime 98.37% <ø> (ø)
packages/context-engine 93.94% <ø> (ø)
packages/electron-server-ipc 93.76% <ø> (ø)
packages/file-loaders 92.21% <ø> (ø)
packages/model-bank 100.00% <ø> (ø)
packages/model-runtime 92.19% <ø> (ø)
packages/prompts 77.29% <ø> (ø)
packages/python-interpreter 96.50% <ø> (ø)
packages/utils 94.50% <ø> (ø)
packages/web-crawler 97.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 74.41% <ø> (ø)
Services 61.47% <ø> (ø)
Server 77.38% <ø> (ø)
Libs 35.68% <ø> (ø)
Utils 83.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arvinxx arvinxx changed the title remove azure ad ♻️ refactor: remove azure-ad auth provider Oct 30, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lobehubbot
Copy link
Member

👍 @arvinxx

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.

@arvinxx arvinxx merged commit 103c4d7 into next Oct 31, 2025
47 checks passed
@arvinxx arvinxx deleted the refactor/remove-ad branch October 31, 2025 03:19
@lobehubbot
Copy link
Member

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

lobehubbot pushed a commit that referenced this pull request Oct 31, 2025
## [Version&nbsp;2.0.0-next.4](v2.0.0-next.3...v2.0.0-next.4)
<sup>Released on **2025-10-31**</sup>

#### ♻ Code Refactoring

- **misc**: Remove azure-ad auth provider.

#### 💄 Styles

- **misc**: Update i18n.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Remove azure-ad auth provider, closes [#9942](#9942) ([103c4d7](103c4d7))

#### Styles

* **misc**: Update i18n, closes [#9944](#9944) ([3a6468f](3a6468f))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 2.0.0-next.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @next size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants